drivers: usb: usb_dc_numaker: make usbd_ep_fifo_copy_from_user void#102021
Merged
fabiobaltieri merged 2 commits intozephyrproject-rtos:mainfrom Jan 15, 2026
Merged
Conversation
numaker_usbd_ep_fifo_copy_from_user() never reports errors and always returns 0. The error check at the call site is therefore dead code. Make the function void and drop the unused error handling. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
josuah
previously approved these changes
Jan 9, 2026
Contributor
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
static void numaker_usbd_setup_fifo_copy_to_user() is void, so it makes sense for copy_from_user() to be void too.
Contributor
|
For consistency, change both |
numaker_usbd_ep_fifo_copy_to_user() never reports errors and always returns 0. The error check at the call site is therefore dead code. Make the function void and drop the unused error handling. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
|
ccli8
approved these changes
Jan 14, 2026
henrikbrixandersen
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numaker_usbd_ep_fifo_copy_from_user() never reports errors and always returns 0.
The error check at the call site is therefore dead code.
Make the function void and drop the unused error handling.